TypeError: Cannot set property data of #<Object> which has only a getter fix#649
Merged
Merged
Conversation
eoL95
changed the title
dougwilson
suggested changes
Apr 11, 2019
Contributor
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Needs a test to prevent regression (test for the original error). I can help create the test if you have steps to reproduce.
dougwilson
suggested changes
Apr 11, 2019
dougwilson
force-pushed
the
feature/cookie-fix
branch
from
6dbb1c1 to
fc628a1
Compare
dougwilson
force-pushed
the
feature/cookie-fix
branch
from
fc628a1 to
3ac7891
Compare
dougwilson
pushed a commit
to eoL95/session
that referenced
this pull request
Apr 11, 2019
dougwilson
force-pushed
the
feature/cookie-fix
branch
from
3ac7891 to
1e3fc39
Compare
dougwilson
approved these changes
Apr 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. In new release you have an error:
TypeError: Cannot set property data of #<Object> which has only a getterSo, this happened because you've changed this code
But in your
cookie.jsfilestrict modeis enabled. That is the reason why JS throws an error.So I think the better way is to define setter for data field in prototype.